Skip to content

/review-local variant of code change analysis#1337

Open
labkey-jeckels wants to merge 4 commits intodevelopfrom
fb_reviewLocal
Open

/review-local variant of code change analysis#1337
labkey-jeckels wants to merge 4 commits intodevelopfrom
fb_reviewLocal

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented Apr 14, 2026

Rationale

We've had success using /review-pr to do automated code reviews of pull requests in GitHub. It would be nice to be able to do the same review locally, before pushing the code or opening the pull request.

Changes

  • Introduce /review-local command to get a data-integrity and security-focused code review on local changes
  • Pull out common guidance to use for both local and PR reviews
  • Manual test
  • Confirm /review-pr still produces expected findings on historical PRs @labkey-jeckels

@labkey-jeckels labkey-jeckels self-assigned this Apr 14, 2026
@labkey-jeckels labkey-jeckels requested a review from a team April 14, 2026 19:54
Steps:
1. Find the current repo root with `git rev-parse --show-toplevel`, then get its parent directory. List all subdirectories of that parent and probe each with `git -C <dir> rev-parse --git-dir 2>/dev/null` to identify sibling git repositories.
2. For each git repository found (including the current one), run the appropriate command:
1. Find the repo root with `git rev-parse --show-toplevel` (call it REPO_ROOT). The repos to check are at these known locations — no probing needed:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude is asking to access directory that's parent of root (which is basically my entire user directory), and if I say no, it aborts. This doesn't happen every time, but I'd say 20% of time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the guidance on how it should run these commands. For me, it reduces confirmation prompts, but I haven't seen this one about accessing the parent directory. Try pulling the latest.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few times and do see fewer confirmation prompts. I also haven't seen it asking user directory any more. Though I did update my CC version and maybe also model between the testings. Overall it's working pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants